From 19023626e62b464a6bca79bb3a59a2567b899487 Mon Sep 17 00:00:00 2001 From: David Wobrock Date: Fri, 7 Feb 2020 23:01:01 +0100 Subject: [PATCH] Introduce a first PY2/PY3 difference for inspect.get(full)argspec call --- django_migration_linter/migration_linter.py | 7 ++++++- setup.py | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/django_migration_linter/migration_linter.py b/django_migration_linter/migration_linter.py index 3065e33..fe28cfc 100644 --- a/django_migration_linter/migration_linter.py +++ b/django_migration_linter/migration_linter.py @@ -12,6 +12,7 @@ from django.core.management import call_command from django.db import DEFAULT_DB_ALIAS, connections, ProgrammingError from django.db.migrations import RunPython from enum import Enum, unique +from six import PY2 from .cache import Cache from .constants import ( @@ -402,7 +403,11 @@ class MigrationLinter(object): else: warning.append(issue) - args_spec = inspect.getfullargspec(runpython.code) + if PY2: + args_spec = inspect.getargspec(runpython.code) + else: + args_spec = inspect.getfullargspec(runpython.code) + if tuple(args_spec.args) != EXPECTED_DATA_MIGRATION_ARGS: issue = { "code": "NAMING_CONVENTION_RUNPYTHON_ARGS", diff --git a/setup.py b/setup.py index 1ff0b10..c87d8d7 100644 --- a/setup.py +++ b/setup.py @@ -35,6 +35,7 @@ setup( "django>=1.11", "appdirs==1.4.3", 'enum34==1.1.6;python_version<"3.4"', + "six==1.14.0", ], extras_require={ "test": [