Large code refactoring

* Add tests
* Remove git dependency (only needed when a git identifier is specified)

tests/unit/test_linter.py

@@ -0,0 +1,107 @@
+# Copyright 2017 3YOURMIND GmbH
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import unittest
+
+from django_migration_linter import MigrationLinter
+from tests import fixtures
+
+
+class TestLinterFunctions(unittest.TestCase):
+    def test_get_sql(self):
+        project_path = fixtures.ADD_NOT_NULL_COLUMN_PROJECT
+        linter = MigrationLinter(project_path)
+        sql_statements = linter.get_sql('test_app', '0001')
+        self.assertEqual(len(sql_statements), 6)
+        self.assertEqual(sql_statements[0], 'BEGIN;')
+        self.assertEqual(sql_statements[-1], 'COMMIT;')
+
+    def test_has_errors(self):
+        project_path = fixtures.MULTI_COMMIT_PROJECT
+        linter = MigrationLinter(project_path)
+        self.assertFalse(linter.has_errors)
+
+        linter.lint_migration('test_app', '0001')
+        self.assertFalse(linter.has_errors)
+
+        linter.lint_migration('test_app', '0002')
+        self.assertTrue(linter.has_errors)
+
+        linter.lint_migration('test_app', '0001')
+        self.assertTrue(linter.has_errors)
+
+    def test_linter_creation(self):
+        with self.assertRaises(ValueError):
+            MigrationLinter('foo/')
+        with self.assertRaises(ValueError):
+            MigrationLinter('/dev/null')
+        with self.assertRaises(ValueError):
+            MigrationLinter(fixtures.NOT_DJANGO_GIT_PROJECT)
+
+    def test_split_migration_long_path(self):
+        input_path = 'apps/the_app/migrations/0001_stuff.py'
+        app, mig = MigrationLinter._split_migration_path(input_path)
+        self.assertEqual(app, 'the_app')
+        self.assertEqual(mig, '0001_stuff')
+
+    def test_split_migration_path(self):
+        input_path = 'the_app/migrations/0001_stuff.py'
+        app, mig = MigrationLinter._split_migration_path(input_path)
+        self.assertEqual(app, 'the_app')
+        self.assertEqual(mig, '0001_stuff')
+
+    def test_split_migration_full_path(self):
+        input_path = '/home/user/djangostuff/apps/the_app/migrations/0001_stuff.py'
+        app, mig = MigrationLinter._split_migration_path(input_path)
+        self.assertEqual(app, 'the_app')
+        self.assertEqual(mig, '0001_stuff')
+
+    def test_ignore_migration_include_apps(self):
+        linter = MigrationLinter(
+            fixtures.ADD_NOT_NULL_COLUMN_PROJECT,
+            include_apps=('test_app2',))
+        self.assertTrue(linter.should_ignore_migration('test_app1', '0001'))
+        self.assertFalse(linter.should_ignore_migration('test_app2', '0001'))
+
+    def test_ignore_migration_exclude_apps(self):
+        linter = MigrationLinter(
+            fixtures.ADD_NOT_NULL_COLUMN_PROJECT,
+            exclude_apps=('test_app1',))
+        self.assertTrue(linter.should_ignore_migration('test_app1', '0001'))
+        self.assertFalse(linter.should_ignore_migration('test_app2', '0001'))
+
+    def test_ignore_migration_name_contains(self):
+        linter = MigrationLinter(
+            fixtures.ADD_NOT_NULL_COLUMN_PROJECT,
+            ignore_name_contains='foo')
+        self.assertTrue(linter.should_ignore_migration('test_app', '0001_foo'))
+        self.assertFalse(linter.should_ignore_migration('test_app', '0002_bar'))
+
+    def test_ignore_migration_full_name(self):
+        linter = MigrationLinter(
+            fixtures.ADD_NOT_NULL_COLUMN_PROJECT,
+            ignore_name=('0001_foo',))
+        self.assertTrue(linter.should_ignore_migration('test_app', '0001_foo'))
+        self.assertFalse(linter.should_ignore_migration('test_app', '0002_bar'))
+
+    def test_gather_all_migrations(self):
+        linter = MigrationLinter(fixtures.CORRECT_PROJECT)
+        migrations = linter._gather_all_migrations()
+        self.assertEqual(len(migrations), 3)
+        self.assertEqual(migrations[0][0], 'test_app1')
+        self.assertEqual(migrations[0][1], '0001_initial')
+        self.assertEqual(migrations[1][0], 'test_app1')
+        self.assertEqual(migrations[1][1], '0002_a_new_null_field')
+        self.assertEqual(migrations[2][0], 'test_app2')
+        self.assertEqual(migrations[2][1], '0001_foo')

tests/unit/test_utils.py

@@ -12,40 +12,61 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import os
 import unittest
 
 from tests import fixtures
-from django_migration_linter import MigrationLinter, valid_folder
+from django_migration_linter.utils import is_django_project, is_git_project, is_directory, find_project_settings_module, split_path
 
 
 class UtilityFunctionTest(unittest.TestCase):
     def tearDown(self, *args, **kwargs):
-        #fixtures.clear_all_git_projects()
+        fixtures.clear_all_git_projects()
         super(
             UtilityFunctionTest,
             self).tearDown(*args, **kwargs)
 
-    def test_split_migration_path(self):
-        input_path = 'apps/the_app/migrations/0001_stuff.py'
-        app, mig = MigrationLinter._split_migration_path(input_path)
-        self.assertEqual(app, 'the_app')
-        self.assertEqual(mig, '0001_stuff')
+    def test_detect_not_git_project(self):
+        self.assertFalse(is_git_project(fixtures.NOT_GIT_DJANGO_PROJECT))
 
-    def test_split_migration_path_2(self):
-        input_path = 'the_app/migrations/0001_stuff.py'
-        app, mig = MigrationLinter._split_migration_path(input_path)
-        self.assertEqual(app, 'the_app')
-        self.assertEqual(mig, '0001_stuff')
+    def test_detect_git_project(self):
+        project_path = fixtures.MULTI_COMMIT_PROJECT
+        fixtures.prepare_git_project(project_path)
+        self.assertTrue(is_git_project(project_path))
 
-    def test_detect_valid_folder(self):
-        test_project_path = fixtures.MULTI_COMMIT_PROJECT
-        fixtures.prepare_git_project(test_project_path)
-        self.assertTrue(valid_folder(test_project_path))
+    def test_detect_django_project(self):
+        self.assertTrue(is_django_project(fixtures.ADD_NOT_NULL_COLUMN_PROJECT))
 
     def test_detect_not_django_project(self):
-        test_project_path = fixtures.NOT_DJANGO_GIT_PROJECT
-        fixtures.prepare_git_project(test_project_path)
-        self.assertFalse(valid_folder(test_project_path))
+        self.assertFalse(is_django_project(fixtures._BASE_DIR))
 
-    def test_detect_not_git_project(self):
-        self.assertFalse(valid_folder(fixtures.NOT_GIT_DJANGO_PROJECT))
+    def test_detect_directory(self):
+        self.assertTrue(is_directory(fixtures.ADD_NOT_NULL_COLUMN_PROJECT))
+
+    def test_detect_not_directory(self):
+        self.assertFalse(is_directory(
+            os.path.join(fixtures.ADD_NOT_NULL_COLUMN_PROJECT, 'manage.py')))
+
+    def test_find_project_settings_module_same_project_name(self):
+        expected = 'test_project_add_not_null_column.settings'
+        actual = find_project_settings_module(fixtures.ADD_NOT_NULL_COLUMN_PROJECT)
+        self.assertEqual(actual, expected)
+
+    def test_find_project_settings_module_different_project_name(self):
+        expected = 'test_project.settings'
+        actual = find_project_settings_module(fixtures.CORRECT_PROJECT)
+        self.assertEqual(actual, expected)
+
+    def test_split_path(self):
+        splitted = split_path('foo/bar/fuz.py')
+        self.assertEqual(len(splitted), 3)
+        self.assertEqual(splitted[0], 'foo')
+        self.assertEqual(splitted[1], 'bar')
+        self.assertEqual(splitted[2], 'fuz.py')
+
+    def test_split_full_path(self):
+        splitted = split_path('/foo/bar/fuz.py')
+        self.assertEqual(len(splitted), 3)
+        self.assertEqual(splitted[0], 'foo')
+        self.assertEqual(splitted[1], 'bar')
+        self.assertEqual(splitted[2], 'fuz.py')