Large code refactoring

* Add tests
* Remove git dependency (only needed when a git identifier is specified)

tests/unit/test_utils.py

@@ -12,40 +12,61 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import os
 import unittest
 
 from tests import fixtures
-from django_migration_linter import MigrationLinter, valid_folder
+from django_migration_linter.utils import is_django_project, is_git_project, is_directory, find_project_settings_module, split_path
 
 
 class UtilityFunctionTest(unittest.TestCase):
     def tearDown(self, *args, **kwargs):
-        #fixtures.clear_all_git_projects()
+        fixtures.clear_all_git_projects()
         super(
             UtilityFunctionTest,
             self).tearDown(*args, **kwargs)
 
-    def test_split_migration_path(self):
-        input_path = 'apps/the_app/migrations/0001_stuff.py'
-        app, mig = MigrationLinter._split_migration_path(input_path)
-        self.assertEqual(app, 'the_app')
-        self.assertEqual(mig, '0001_stuff')
+    def test_detect_not_git_project(self):
+        self.assertFalse(is_git_project(fixtures.NOT_GIT_DJANGO_PROJECT))
 
-    def test_split_migration_path_2(self):
-        input_path = 'the_app/migrations/0001_stuff.py'
-        app, mig = MigrationLinter._split_migration_path(input_path)
-        self.assertEqual(app, 'the_app')
-        self.assertEqual(mig, '0001_stuff')
+    def test_detect_git_project(self):
+        project_path = fixtures.MULTI_COMMIT_PROJECT
+        fixtures.prepare_git_project(project_path)
+        self.assertTrue(is_git_project(project_path))
 
-    def test_detect_valid_folder(self):
-        test_project_path = fixtures.MULTI_COMMIT_PROJECT
-        fixtures.prepare_git_project(test_project_path)
-        self.assertTrue(valid_folder(test_project_path))
+    def test_detect_django_project(self):
+        self.assertTrue(is_django_project(fixtures.ADD_NOT_NULL_COLUMN_PROJECT))
 
     def test_detect_not_django_project(self):
-        test_project_path = fixtures.NOT_DJANGO_GIT_PROJECT
-        fixtures.prepare_git_project(test_project_path)
-        self.assertFalse(valid_folder(test_project_path))
+        self.assertFalse(is_django_project(fixtures._BASE_DIR))
 
-    def test_detect_not_git_project(self):
-        self.assertFalse(valid_folder(fixtures.NOT_GIT_DJANGO_PROJECT))
+    def test_detect_directory(self):
+        self.assertTrue(is_directory(fixtures.ADD_NOT_NULL_COLUMN_PROJECT))
+
+    def test_detect_not_directory(self):
+        self.assertFalse(is_directory(
+            os.path.join(fixtures.ADD_NOT_NULL_COLUMN_PROJECT, 'manage.py')))
+
+    def test_find_project_settings_module_same_project_name(self):
+        expected = 'test_project_add_not_null_column.settings'
+        actual = find_project_settings_module(fixtures.ADD_NOT_NULL_COLUMN_PROJECT)
+        self.assertEqual(actual, expected)
+
+    def test_find_project_settings_module_different_project_name(self):
+        expected = 'test_project.settings'
+        actual = find_project_settings_module(fixtures.CORRECT_PROJECT)
+        self.assertEqual(actual, expected)
+
+    def test_split_path(self):
+        splitted = split_path('foo/bar/fuz.py')
+        self.assertEqual(len(splitted), 3)
+        self.assertEqual(splitted[0], 'foo')
+        self.assertEqual(splitted[1], 'bar')
+        self.assertEqual(splitted[2], 'fuz.py')
+
+    def test_split_full_path(self):
+        splitted = split_path('/foo/bar/fuz.py')
+        self.assertEqual(len(splitted), 3)
+        self.assertEqual(splitted[0], 'foo')
+        self.assertEqual(splitted[1], 'bar')
+        self.assertEqual(splitted[2], 'fuz.py')