public/django-migration-linter
15
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adapt migration linter to handled returned warnings

Browse Source
This commit is contained in:
David Wobrock committed 2021-06-19 18:15:40 +02:00
1 parent 343d163c88
commit 70db245df3
1 file changed
+10 -4
Download Patch File Download Diff File Expand all files Collapse all files
django_migration_linter/migration_linter.py
+10 -4
View File
@@ -159,17 +159,19 @@ class MigrationLinter(object):
return return
sql_statements = self.get_sql(app_label, migration_name) sql_statements = self.get_sql(app_label, migration_name)
errors, ignored = analyse_sql_statements( errors, ignored, warnings = analyse_sql_statements(
sql_statements, sql_statements,
settings.DATABASES[self.database]["ENGINE"], settings.DATABASES[self.database]["ENGINE"],
self.exclude_migration_tests, self.exclude_migration_tests,
) )
err, ignored_data, warnings = self.analyse_data_migration(migration) err, ignored_data, warnings_data = self.analyse_data_migration(migration)
if err: if err:
errors += err errors += err
if ignored_data: if ignored_data:
ignored += ignored_data ignored += ignored_data
if warnings_data:
warnings += warnings_data
if self.warnings_as_errors: if self.warnings_as_errors:
errors += warnings errors += warnings
@@ -616,7 +618,7 @@ class MigrationLinter(object):
else: else:
sql_statements.append(runsql.sql) sql_statements.append(runsql.sql)
sql_errors, sql_ignored = analyse_sql_statements( sql_errors, sql_ignored, sql_warnings = analyse_sql_statements(
sql_statements, sql_statements,
settings.DATABASES[self.database]["ENGINE"], settings.DATABASES[self.database]["ENGINE"],
self.exclude_migration_tests, self.exclude_migration_tests,
@@ -625,6 +627,8 @@ class MigrationLinter(object):
error += sql_errors error += sql_errors
if sql_ignored: if sql_ignored:
ignored += sql_ignored ignored += sql_ignored
if sql_warnings:
warnings += sql_warnings
# And analysse the reverse SQL # And analysse the reverse SQL
if runsql.reversible and runsql.reverse_sql != RunSQL.noop: if runsql.reversible and runsql.reverse_sql != RunSQL.noop:
@@ -644,7 +648,7 @@ class MigrationLinter(object):
else: else:
sql_statements.append(runsql.reverse_sql) sql_statements.append(runsql.reverse_sql)
sql_errors, sql_ignored = analyse_sql_statements( sql_errors, sql_ignored, sql_warnings = analyse_sql_statements(
sql_statements, sql_statements,
settings.DATABASES[self.database]["ENGINE"], settings.DATABASES[self.database]["ENGINE"],
self.exclude_migration_tests, self.exclude_migration_tests,
@@ -653,5 +657,7 @@ class MigrationLinter(object):
error += sql_errors error += sql_errors
if sql_ignored: if sql_ignored:
ignored += sql_ignored ignored += sql_ignored
if sql_warnings:
warnings += sql_warnings
return error, ignored, warning return error, ignored, warning