Add warning if RunPython model variable name not the same as model class

This commit is contained in:
David-Wobrock authored and David Wobrock committed 2020-11-26 19:02:57 +01:00
1 parent 601e02e024
commit 780630131f
4 files changed
+180 -12

No files matched your search

+14 -12
View File
@@ -19,20 +19,22 @@ We are happy to add more if you can specify them to us.
On data migrations, the linter will show a warning when:
* you are missing a reverse migration
* the RunPython arguments do not respect the naming convention `apps, schema_editor`
* the model variable name is different from the model class name in the `get_model` call
## Codes
You can ignore check through the `--exclude-migration-test` option and specifying any of the codes:
| Code | Description |
|-----------------------------------|----------------------------------------------------------------------|
|`NOT_NULL` | Not NULL constraint on columns
|`DROP_COLUMN` | Dropping columns
|`DROP_TABLE` | Dropping tables
|`RENAME_COLUMN` | Renaming columns
|`RENAME_TABLE` | Renaming tables
|`ALTER_COLUMN` | Altering columns (could be backward compatible)
|`ADD_UNIQUE` | Add unique constraints
|`REVERSIBLE_DATA_MIGRATION` | RunPython data migration is not reversible (missing reverse code)
|`NAMING_CONVENTION_RUNPYTHON_ARGS` | By convention, RunPython names two arguments: apps, schema_editor
|`DATA_MIGRATION_MODEL_IMPORT` | Missing apps.get_model() calls for model
| Code | Description |
|-------------------------------------|----------------------------------------------------------------------|
|`NOT_NULL` | Not NULL constraint on columns
|`DROP_COLUMN` | Dropping columns
|`DROP_TABLE` | Dropping tables
|`RENAME_COLUMN` | Renaming columns
|`RENAME_TABLE` | Renaming tables
|`ALTER_COLUMN` | Altering columns (could be backward compatible)
|`ADD_UNIQUE` | Add unique constraints
|`REVERSIBLE_DATA_MIGRATION` | RunPython data migration is not reversible (missing reverse code)
|`NAMING_CONVENTION_RUNPYTHON_ARGS` | By convention, RunPython names two arguments: apps, schema_editor
|`DATA_MIGRATION_MODEL_IMPORT` | Missing apps.get_model() calls for model
|`DATA_MIGRATION_MODEL_VARIABLE_NAME` | The model variable name is different from the model class itself