From 88a7b0812ac3c0edb4e8bdb6e7e72832eca521f2 Mon Sep 17 00:00:00 2001 From: Phillip Verheyden Date: Thu, 24 Feb 2022 17:11:12 -0600 Subject: [PATCH] Allow project_root_path and verbosity to come from Django settings And still fallback to DJANGO_SETTINGS_MODULE environ for project_root_path if not explicitly set Fixes #203 --- .../management/commands/lintmigrations.py | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/django_migration_linter/management/commands/lintmigrations.py b/django_migration_linter/management/commands/lintmigrations.py index 379bf3a..ab44967 100644 --- a/django_migration_linter/management/commands/lintmigrations.py +++ b/django_migration_linter/management/commands/lintmigrations.py @@ -132,15 +132,6 @@ class Command(BaseCommand): register_linting_configuration_options(parser) def handle(self, *args, **options): - if options["project_root_path"]: - settings_path = options["project_root_path"] - else: - settings_path = os.path.dirname( - import_module(os.getenv("DJANGO_SETTINGS_MODULE")).__file__ - ) - - configure_logging(options["verbosity"]) - django_settings_options = self.read_django_settings(options) config_options = self.read_config_file(options) toml_options = self.read_toml_file(options) @@ -157,8 +148,13 @@ class Command(BaseCommand): all_warnings_as_errors, ) = extract_warnings_as_errors_option(options["warnings_as_errors"]) + configure_logging(options["verbosity"]) + + root_path = options["project_root_path"] or os.path.dirname( + import_module(os.getenv("DJANGO_SETTINGS_MODULE")).__file__ + ) linter = MigrationLinter( - settings_path, + root_path, ignore_name_contains=options["ignore_name_contains"], ignore_name=options["ignore_name"], include_name_contains=options["include_name_contains"],