diff --git a/CHANGELOG.md b/CHANGELOG.md index 10c5b4a..b268533 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## 2.2.1 + +Fixed bug: +* Correctly detect `apps.get_models` when on multiple lines in data migration + ## 2.2.0 * Make summary output more friendly (Thanks to @vald-phoenix) diff --git a/django_migration_linter/constants.py b/django_migration_linter/constants.py index 84c8b53..c43e096 100644 --- a/django_migration_linter/constants.py +++ b/django_migration_linter/constants.py @@ -1,6 +1,6 @@ from appdirs import user_cache_dir -__version__ = "2.2.0" +__version__ = "2.2.1" DEFAULT_CACHE_PATH = user_cache_dir("django-migration-linter", version=__version__) diff --git a/tests/functional/test_data_migrations.py b/tests/functional/test_data_migrations.py index e3953a1..c1d5485 100644 --- a/tests/functional/test_data_migrations.py +++ b/tests/functional/test_data_migrations.py @@ -79,8 +79,12 @@ class DataMigrationDetectionTestCase(unittest.TestCase): def test_correct_get_model_import(self): def correct_importing_model_forward(apps, schema_editor): MyModel = apps.get_model("app_data_migrations", "MyModel") + MyVeryLongLongLongModel = apps.get_model( + "app_data_migrations", "MyVeryLongLongLongModel" + ) MyModel.objects.filter(id=1).first() + MyVeryLongLongLongModel.objects.filter(id=1).first() issues = MigrationLinter.get_data_migration_model_import_issues( correct_importing_model_forward diff --git a/tests/test_project/app_data_migrations/migrations/0001_initial.py b/tests/test_project/app_data_migrations/migrations/0001_initial.py index 389b564..b62d558 100644 --- a/tests/test_project/app_data_migrations/migrations/0001_initial.py +++ b/tests/test_project/app_data_migrations/migrations/0001_initial.py @@ -24,5 +24,5 @@ class Migration(migrations.Migration): ), ("myfield", models.IntegerField()), ], - ), + ) ] diff --git a/tests/test_project/app_data_migrations/migrations/0002_missing_reverse.py b/tests/test_project/app_data_migrations/migrations/0002_missing_reverse.py index 7d81139..0913d82 100644 --- a/tests/test_project/app_data_migrations/migrations/0002_missing_reverse.py +++ b/tests/test_project/app_data_migrations/migrations/0002_missing_reverse.py @@ -9,10 +9,6 @@ def update_things(apps, schema_editor): class Migration(migrations.Migration): - dependencies = [ - ("app_data_migrations", "0001_initial"), - ] + dependencies = [("app_data_migrations", "0001_initial")] - operations = [ - migrations.RunPython(update_things), - ] + operations = [migrations.RunPython(update_things)] diff --git a/tests/test_project/app_data_migrations/migrations/0003_incorrect_arguments.py b/tests/test_project/app_data_migrations/migrations/0003_incorrect_arguments.py index ca8b548..4993201 100644 --- a/tests/test_project/app_data_migrations/migrations/0003_incorrect_arguments.py +++ b/tests/test_project/app_data_migrations/migrations/0003_incorrect_arguments.py @@ -13,10 +13,6 @@ def forward_weird_name(arg1, arg2): class Migration(migrations.Migration): - dependencies = [ - ("app_data_migrations", "0002_missing_reverse"), - ] + dependencies = [("app_data_migrations", "0002_missing_reverse")] - operations = [ - migrations.RunPython(forward_weird_name, backward_weirdly_named), - ] + operations = [migrations.RunPython(forward_weird_name, backward_weirdly_named)]