From abb6233f4480e401f1f9c70ee269f1b54dd6df84 Mon Sep 17 00:00:00 2001
From: Artem Streltsov <kekekekule@yandex.ru>
Date: Wed, 22 Nov 2023 11:31:10 +0300
Subject: [PATCH] Ignore 'IS NOT NULL' statements.

---
 src/django_migration_linter/sql_analyser/base.py | 2 +-
 tests/unit/test_sql_analyser.py                  | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/django_migration_linter/sql_analyser/base.py b/src/django_migration_linter/sql_analyser/base.py
index 131652e..0dcd9b6 100644
--- a/src/django_migration_linter/sql_analyser/base.py
+++ b/src/django_migration_linter/sql_analyser/base.py
@@ -40,7 +40,7 @@ def has_not_null_column(sql_statements: list[str], **kwargs) -> bool:
             ends_with_default = False
     return (
         any(
-            re.search("(?<!DROP )NOT NULL", sql)
+            re.search("(?<!DROP )(?<!IS )NOT NULL", sql)
             and not (sql.startswith("CREATE TABLE") or sql.startswith("CREATE INDEX"))
             for sql in sql_statements
         )
diff --git a/tests/unit/test_sql_analyser.py b/tests/unit/test_sql_analyser.py
index b0a78aa..48daf0d 100644
--- a/tests/unit/test_sql_analyser.py
+++ b/tests/unit/test_sql_analyser.py
@@ -74,6 +74,12 @@ class MySqlAnalyserTestCase(SqlAnalyserTestCase):
         ]
         self.assertValidSql(sql)
 
+    def test_add_trigger(self):
+        sql = [
+            'CREATE OR REPLACE FUNCTION "public"._pgtrigger_should_ignore( trigger_name NAME ) RETURNS BOOLEAN AS $$ DECLARE _pgtrigger_ignore TEXT[]; _result BOOLEAN; BEGIN BEGIN SELECT INTO _pgtrigger_ignore CURRENT_SETTING(\'pgtrigger.ignore\'); EXCEPTION WHEN OTHERS THEN END; IF _pgtrigger_ignore IS NOT NULL THEN SELECT trigger_name = ANY(_pgtrigger_ignore) INTO _result; RETURN _result; ELSE RETURN FALSE; END IF; END; $$ LANGUAGE plpgsql; CREATE OR REPLACE FUNCTION pgtrigger_update_field_5d480() RETURNS TRIGGER AS $$ BEGIN IF ("public"._pgtrigger_should_ignore(TG_NAME) IS TRUE) THEN IF (TG_OP = \'DELETE\') THEN RETURN OLD; ELSE RETURN NEW; END IF; END IF; NEW.field := 1; RETURN NEW; END; $$ LANGUAGE plpgsql; DROP TRIGGER IF EXISTS pgtrigger_update_field_5d480 ON "app_add_trigger_a"; CREATE TRIGGER pgtrigger_update_field_5d480 BEFORE UPDATE ON "app_add_trigger_a" FOR EACH ROW WHEN (OLD."field" IS NOT DISTINCT FROM NEW."field") EXECUTE PROCEDURE pgtrigger_update_field_5d480(); COMMENT ON TRIGGER pgtrigger_update_field_5d480 ON "app_add_trigger_a" IS \'8d42224131cefae42a0fa95e72ee29e16e2058ad\'; ; COMMIT;'
+        ]
+        self.assertValidSql(sql)
+
     def test_unique_together(self):
         sql = "ALTER TABLE `app_unique_together_a` ADD CONSTRAINT `app_unique_together_a_int_field_char_field_979ac7d8_uniq` UNIQUE (`int_field`, `char_field`);"
         self.assertBackwardIncompatibleSql(sql)