From b3816613d5682029109fa819ce29a3aad487e207 Mon Sep 17 00:00:00 2001
From: David Wobrock <david.wobrock@gmail.com>
Date: Sat, 20 Jun 2020 17:49:32 +0200
Subject: [PATCH] Fix #115 -- Detect correctly if a field ends with a default
 value or a dropped default

---
 django_migration_linter/sql_analyser/base.py | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/django_migration_linter/sql_analyser/base.py b/django_migration_linter/sql_analyser/base.py
index ef7b4c3..5fa0d79 100644
--- a/django_migration_linter/sql_analyser/base.py
+++ b/django_migration_linter/sql_analyser/base.py
@@ -8,10 +8,19 @@ logger = logging.getLogger(__name__)
 
 def has_not_null_column(sql_statements, **kwargs):
     # TODO: improve to detect that the same column is concerned
-    return any(
-        re.search("(?<!DROP )NOT NULL", sql) and not sql.startswith("CREATE TABLE")
-        for sql in sql_statements
-    ) and not any("SET DEFAULT" in sql for sql in sql_statements)
+    ends_with_default = None
+    for sql in sql_statements:
+        if "SET DEFAULT" in sql:
+            ends_with_default = True
+        elif "DROP DEFAULT" in sql:
+            ends_with_default = False
+    return (
+        any(
+            re.search("(?<!DROP )NOT NULL", sql) and not sql.startswith("CREATE TABLE")
+            for sql in sql_statements
+        )
+        and ends_with_default is False
+    )
 
 
 def has_add_unique(sql_statements, **kwargs):